test(profiling): fix flaky exception raise test by gyuheon0h · Pull Request #19139 · DataDog/dd-trace-py

gyuheon0h · 2026-07-17T12:43:21Z

Description

When sampling_interval=1, skip Poisson sampling so every exception is collected instead of allowing random gaps of 2+. That removes the flake where a stray exception could consume the sample slot and miss intentional exceptions thrown. Used claude for verif script

Testing

ran the exception test file 100x...

# Build -k expression from test function names in the file, then loop 100x
scripts/ddtest bash -c '
set -e
KEXPR=$(python3 - <<'"'"'PY'"'"'
import ast, pathlib
src = pathlib.Path("tests/profiling/collector/test_exception.py").read_text()
names = [n.name for n in ast.walk(ast.parse(src)) if isinstance(n, ast.FunctionDef) and n.name.startswith("test_")]
print(" or ".join(names))
PY
)
echo "Filter: $KEXPR"
echo "Collect check:"
riot -v run --pass-env -s daba82d -- -k "$KEXPR" --collect-only -q 2>&1 | tail -30

fail=0
passed=0
for i in $(seq 1 100); do
  if riot -v run --pass-env -s daba82d -- -k "$KEXPR" --tb=line -q >/tmp/exc_file.out 2>&1; then
    passed=$((passed+1))
    echo "PASS $i/100"
  else
    echo "FAIL on run $i/100"
    tail -80 /tmp/exc_file.out
    fail=1
    break
  fi
done
echo "RESULT: passed=$passed/100 fail=$fail"
exit $fail
'

PASS 1/100
PASS 2/100
PASS 3/100
PASS 4/100
...
PASS 99/100
PASS 100/100

Risks

Additional Notes

…3Z44N DD_TFZHZD DD_6VMAUN DD_SAXCT8

gyuheon0h · 2026-07-17T12:43:38Z

test(profiling): fix flaky exception raise test #19139 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

cit-pr-commenter-54b7da · 2026-07-17T12:44:20Z

Circular import analysis

⚠️ Existing circular imports

There are 45 circular imports that already exist on the base branch and have not been changed by this PR.

Show existing cycles (showing 5 of 45 shortest)

ddtrace.internal.datastreams -> ddtrace.internal.datastreams.kafka -> ddtrace.internal.datastreams
ddtrace.internal.datastreams -> ddtrace.internal.datastreams.botocore -> ddtrace.internal.datastreams
ddtrace.internal.datastreams -> ddtrace.internal.datastreams.aiokafka -> ddtrace.internal.datastreams
ddtrace.internal.core -> ddtrace._trace.span -> ddtrace.internal.core
ddtrace.internal.datastreams -> ddtrace.internal.datastreams.kombu -> ddtrace.internal.datastreams

To see all cycles, download the cycles-base.json and cycles-pr.json artifacts from this CI job and run:
uv run --script scripts/import-analysis/cycles.py compare cycles-base.json cycles-pr.json

datadog-datadog-prod-us1-2 · 2026-07-17T12:44:22Z

Tests

⚠️ Warnings

🚦 10 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-py | build linux serverless: [arm64, cp315-cp315, v113741357-d2b8243-manylinux2014_aarch64, 1]

DataDog/apm-reliability/dd-trace-py | build linux serverless: [arm64, cp315-cp315, v113741589-d2b8243-musllinux_1_2_aarch64, 1]

DataDog/apm-reliability/dd-trace-py | build linux: [amd64, cp315-cp315, v113741238-d2b8243-manylinux2014_x86_64]

View all 10 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: ff3d8d2 | Docs | Datadog PR Page | Give us feedback!}

gyuheon0h · 2026-07-17T14:27:46Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-07-17T14:27:51Z

View all feedbacks in Devflow UI.

2026-07-17 14:27:51 UTC ℹ️ Start processing command /merge

2026-07-17 14:27:56 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 58m (p90).

2026-07-17 14:50:23 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for a556879:

baseline:build

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

gyuheon0h · 2026-07-17T14:58:37Z

/merge -f "MQ is not working and the only PRs in the queue currently are mine"

gh-worker-devflow-routing-ef8351 · 2026-07-17T14:58:44Z

View all feedbacks in Devflow UI.

2026-07-17 14:58:41 UTC ℹ️ Start processing command /merge -f "MQ is not working and the only PRs in the queue currently are mine"
If you need support, contact us on Slack #devflow!

2026-07-17 14:58:42 UTC ❌ Devflow: /merge -f "MQ is not working and the only PRs in the queue currently are mine"

Arguments errors:

--skip-checks: field is a boolean, but a value was provided. To set it to false, you need to omit it.

If you need support, contact us on Slack #devflow with those details!

gyuheon0h · 2026-07-17T14:59:01Z

/merge -f

gh-worker-devflow-routing-ef8351 · 2026-07-17T14:59:06Z

View all feedbacks in Devflow UI.

2026-07-17 14:59:06 UTC ℹ️ Start processing command /merge -f

2026-07-17 14:59:08 UTC ❌ MergeQueue

You need to provide a reason for skipping checks

gyuheon0h · 2026-07-17T15:01:30Z

/merge -f --reason "MQ is not working and I am the only PRs in merge queue right now"

gh-worker-devflow-routing-ef8351 · 2026-07-17T15:01:35Z

View all feedbacks in Devflow UI.

2026-07-17 15:01:35 UTC ℹ️ Start processing command /merge -f --reason "MQ is not working and I am the only PRs in merge queue right now"

2026-07-17 15:01:39 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 0s (p90).

2026-07-17 15:01:50 UTC ℹ️ MergeQueue: This merge request was merged

Warning

This change was merged without running any pre merge CI checks

Reason: MQ is not working and I am the only PRs in merge queue right now

cit-pr-commenter-54b7da · 2026-07-17T15:03:05Z

Codeowners resolved as

ddtrace/profiling/collector/_exception.pyx                              @DataDog/profiling-python
tests/profiling/collector/test_exception.py                             @DataDog/profiling-python

gyuheon0h added 2 commits July 17, 2026 08:39

interval = 1 means to sample **every** exception

c1f9812

Fix flaky test DD_VPBQBC DD_JTEUUX DD_6TMMN8 DD_841FBY DD_STXYRA DD_T…

ff3d8d2

…3Z44N DD_TFZHZD DD_6VMAUN DD_SAXCT8

gyuheon0h changed the title ~~interval = 1 means to sample **every** exception~~ chore(profiling): sample every exception when internal is 1 Jul 17, 2026

gyuheon0h added the changelog/no-changelog A changelog entry is not required for this PR. label Jul 17, 2026

gyuheon0h changed the title ~~chore(profiling): sample every exception when internal is 1~~ chore(profiling): fix flaky exception raise test Jul 17, 2026

KowalskiThomas changed the title ~~chore(profiling): fix flaky exception raise test~~ test(profiling): fix flaky exception raise test Jul 17, 2026

KowalskiThomas added the Profiling Continous Profling label Jul 17, 2026

KowalskiThomas approved these changes Jul 17, 2026

View reviewed changes

gyuheon0h marked this pull request as ready for review July 17, 2026 13:06

gyuheon0h requested a review from a team as a code owner July 17, 2026 13:06

gyuheon0h requested a review from vlad-scherbich July 17, 2026 13:06

KowalskiThomas approved these changes Jul 17, 2026

View reviewed changes

gh-worker-dd-mergequeue-cf854d Bot merged commit d840f54 into main Jul 17, 2026
453 of 455 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the gyuheon0h/harden-flaky-exc-tests branch July 17, 2026 15:01

Uh oh!

Conversation

gyuheon0h commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Risks

Additional Notes

Uh oh!

gyuheon0h commented Jul 17, 2026

Uh oh!

cit-pr-commenter-54b7da Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Circular import analysis

⚠️ Existing circular imports

Uh oh!

datadog-datadog-prod-us1-2 Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

ℹ️ Info

Uh oh!

gyuheon0h commented Jul 17, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

gyuheon0h commented Jul 17, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jul 17, 2026

Uh oh!

gyuheon0h commented Jul 17, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gyuheon0h commented Jul 17, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

cit-pr-commenter-54b7da Bot commented Jul 17, 2026

Codeowners resolved as

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gyuheon0h commented Jul 17, 2026 •

edited

Loading

cit-pr-commenter-54b7da Bot commented Jul 17, 2026 •

edited

Loading

datadog-datadog-prod-us1-2 Bot commented Jul 17, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Jul 17, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Jul 17, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Jul 17, 2026 •

edited

Loading